[webkit-reviews] review granted: [Bug 116062] Upstream iOS Clipboard and Pasteboard changes : [Attachment 201635] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 116062: Upstream iOS Clipboard and Pasteboard changes
https://bugs.webkit.org/show_bug.cgi?id=116062

Attachment 201635: Patch v1
https://bugs.webkit.org/attachment.cgi?id=201635&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201635&action=review


> Source/WebCore/ChangeLog:11
> +	   (WebCore):

Normally better to remove lines like this when prepare-ChangeLog adds them.

> Source/WebCore/ChangeLog:16
> +	   (WebCore):
> +	   (ClipboardIOS):
> +	   (WebCore::ClipboardIOS::create):

I don’t think we need to list the functions for added files. I usually delete
them.

> Source/WebCore/ChangeLog:38
> +	   (WebCore):
> +	   (WebCore::Clipboard::create):
> +	   (WebCore::ClipboardIOS::ClipboardIOS):
> +	   (WebCore::ClipboardIOS::~ClipboardIOS):
> +	   (WebCore::ClipboardIOS::hasData):
> +	   (WebCore::utiTypeFromCocoaType):
> +	   (WebCore::cocoaTypeFromHTMLClipboardType):
> +	   (WebCore::addHTMLClipboardTypesForCocoaType):
> +	   (WebCore::ClipboardIOS::clearData):
> +	   (WebCore::ClipboardIOS::clearAllData):
> +	   (WebCore::ClipboardIOS::getData):
> +	   (WebCore::ClipboardIOS::setData):
> +	   (WebCore::ClipboardIOS::types):
> +	   (WebCore::ClipboardIOS::files):
> +	   (WebCore::ClipboardIOS::writeRange):
> +	   (WebCore::ClipboardIOS::writePlainText):
> +	   (WebCore::ClipboardIOS::writeURL):
> +	   (WebCore::ClipboardIOS::declareAndWriteDragImage):
> +	   (WebCore::ClipboardIOS::createDragImage):
> +	   (WebCore::ClipboardIOS::setDragImage):
> +	   (WebCore::ClipboardIOS::setDragImageElement):

Ditto.

> Source/WebCore/ChangeLog:58
> +	   (WebCore):
> +	   (WebCore::Pasteboard::generalPasteboard):
> +	   (WebCore::Pasteboard::Pasteboard):
> +	   (WebCore::Pasteboard::clear):
> +	   (WebCore::Pasteboard::getStringSelection):
> +	   (WebCore::Pasteboard::writeSelection):
> +	   (WebCore::Pasteboard::writePlainText):
> +	   (WebCore::Pasteboard::writeImage):
> +	   (WebCore::Pasteboard::writeClipboard):
> +	   (WebCore::Pasteboard::canSmartReplace):
> +	   (WebCore::Pasteboard::plainText):
> +	   (WebCore::supportedImageTypes):
> +	   (WebCore::Pasteboard::supportedPasteboardTypes):
> +	   (WebCore::uniqueURLWithRelativePart):
> +	   (WebCore::documentFragmentWithImageResource):
> +	   (WebCore::documentFragmentWithLink):
> +	   (WebCore::documentFragmentWithRTF):
> +	   (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
> +	   (WebCore::Pasteboard::documentFragment):

Ditto.