[webkit-reviews] review denied: [Bug 114944] [BlackBerry] Crash due to an assert running test editing/execCommand/indent-paragraphs.html : [Attachment 199009] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 114944: [BlackBerry] Crash due to an assert running test
editing/execCommand/indent-paragraphs.html
https://bugs.webkit.org/show_bug.cgi?id=114944

Attachment 199009: Patch
https://bugs.webkit.org/attachment.cgi?id=199009&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199009&action=review


Looks great, but the new early exit needs to be verified and at least an
error/log has to be there.

> Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp:160
> +    if (!NetworkManager::instance()->startJob(playerId, handle, frame,
defersLoading))

It would be nice to set the error param here.