[webkit-reviews] review granted: [Bug 115721] [GTK] Always use EGL to create the GL context when running on Wayland : [Attachment 201536] Always use EGL when running on Wayland to create GL context

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Iago Toral
<itoral at igalia.com>'s request for review:
Bug 115721: [GTK] Always use EGL to create the GL context when running on
Wayland
https://bugs.webkit.org/show_bug.cgi?id=115721

Attachment 201536: Always use EGL when running on Wayland to create GL context
https://bugs.webkit.org/attachment.cgi?id=201536&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201536&action=review


> Source/WebCore/platform/graphics/cairo/GLContext.cpp:131
> +#if PLATFORM(GTK) && defined(GDK_WINDOWING_WAYLAND) && USE(EGL)
> +    GdkDisplay* display =
gdk_display_manager_get_default_display(gdk_display_manager_get());
> +
> +    if (GDK_IS_WAYLAND_DISPLAY(display)) {
> +	   if (OwnPtr<GLContext> eglContext =
GLContextEGL::createContext(windowHandle, sharingContext))
> +	       return eglContext.release();
> +	   return nullptr;

It's a pity there is no platform-independent way to detect that wayland is
running, but this will suffice for now.