[webkit-reviews] review granted: [Bug 116009] [Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac : [Attachment 201529] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 116009: [Mac] Move writeRange/PlainText/URL from ClipboardMac to
PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116009

Attachment 201529: Patch
https://bugs.webkit.org/attachment.cgi?id=201529&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201529&action=review


r=me

> Source/WebCore/dom/Clipboard.cpp:321
> +void Clipboard::writeRange(Range* range, Frame* frame)
> +{
> +    ASSERT(range);
> +    ASSERT(frame);

I'm starting to wonder why we bother with things like this instead of passing
things by reference where they are always supposed to be non-null.

> Source/WebCore/dom/Clipboard.cpp:322
> +    // FIXME: This is design mistake, a layering violation that should be
fixed.

a* design mistake

> Source/WebCore/dom/Clipboard.cpp:336
> +    // FIXME: This is design mistake, a layering violation that should be
fixed.

*a design mistake