[webkit-reviews] review granted: [Bug 114044] [GStreamer] cannot seek after video finished : [Attachment 201346] style fixed

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 114044: [GStreamer] cannot seek after video finished
https://bugs.webkit.org/show_bug.cgi?id=114044

Attachment 201346: style fixed
https://bugs.webkit.org/attachment.cgi?id=201346&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201346&action=review


Looks good, only a little nit to fix before landing. Thanks!

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:513
> +    if (getStateResult == GST_STATE_CHANGE_ASYNC || (state !=
GST_STATE_PAUSED && state != GST_STATE_PLAYING) || m_isEndReached) {

the state test can be simplified to state < GST_STATE_PAUSED I think