[webkit-reviews] review granted: [Bug 115979] [Mac] Give every Clipboard an underlying Pasteboard : [Attachment 201481] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 115979: [Mac] Give every Clipboard an underlying Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=115979

Attachment 201481: Patch
https://bugs.webkit.org/attachment.cgi?id=201481&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201481&action=review


r=me, glad to see this is moving :)

> Source/WebCore/dom/Clipboard.h:37
> +#define USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS !PLATFORM(MAC)

I would have named this WTF_USE_LEGACY_... and used #if USE(LEGACY_...)

> Source/WebCore/platform/mac/ClipboardMac.mm:60
> -    : Clipboard(policy, clipboardType)
> +    : Clipboard(policy, clipboardType, Pasteboard::create(m_pasteboardName))

>      , m_pasteboardName(pasteboardName)

Is m_pasteboardName guaranteed to be initialized before you pass it to the base
class ctor here?