[webkit-reviews] review granted: [Bug 115981] toDataURL can return an empty image in some cases : [Attachment 201482] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 12 01:22:21 PDT 2013
Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 115981: toDataURL can return an empty image in some cases
https://bugs.webkit.org/show_bug.cgi?id=115981
Attachment 201482: Patch
https://bugs.webkit.org/attachment.cgi?id=201482&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201482&action=review
> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:453
> + CGContextFlush(context()->platformContext());
> +#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1070
> + m_data.m_lastFlushTime = currentTimeMS();
> +#endif
Could we make this share code with the ImageBuffer::context flush? Or is that
not worth it?
More information about the webkit-reviews
mailing list