[webkit-reviews] review granted: [Bug 115967] [GTK] Add a basic cmake build for WTF and JavaScriptCore : [Attachment 201475] Try to fix the EFL build

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 115967: [GTK] Add a basic cmake build for WTF and JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=115967

Attachment 201475: Try to fix the EFL build
https://bugs.webkit.org/attachment.cgi?id=201475&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201475&action=review


Looks good to me, assuming commnets are fixed in Source/cmake/Find*.cmake

> Source/JavaScriptCore/PlatformGTK.cmake:2
> +    jit/ExecutableAllocatorFixedVMPool.cpp

We should try to move this out from the GTK specific cmake file into the shared
cmake file in a separate/follow-up patch if possible. It seem
jit/ExecutableAllocatorFixedVMPool.cpp has a guard already.

> Source/WTF/wtf/PlatformGTK.cmake:3
> +    OSAllocatorPosix.cpp
> +    OSAllocatorWin.cpp

Ditto for these 2 files and possible others in this list.

> Source/cmake/FindGAIL3.cmake:6
> +#  GAIL3_FOUND - system has Cairo
> +#  GAIL3_INCLUDE_DIRS - the Cairo include directories
> +#  GAIL3_LIBRARIES - link these to use Cairo

Cairo --> Gail3.

> Source/cmake/FindGDK3.cmake:6
> +#  GDK3_FOUND - system has Cairo
> +#  GDK3_INCLUDE_DIRS - the Cairo include directories
> +#  GDK3_LIBRARIES - link these to use Cairo

Cairo -> GDK3

> Source/cmake/FindGTK3.cmake:6
> +#  GTK3_FOUND - system has Cairo
> +#  GTK3_INCLUDE_DIRS - the Cairo include directories
> +#  GTK3_LIBRARIES - link these to use Cairo

Cairo -> GTK3.

> Source/cmake/FindXt.cmake:6
> +#  XT_FOUND - system has Cairo
> +#  XT_INCLUDE_DIRS - the Cairo include directories
> +#  XT_LIBRARIES - link these to use Cairo

Cairo -> Xt.