[webkit-reviews] review requested: [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX : [Attachment 201462] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 11 10:29:27 PDT 2013


Sergio Correia <sergio.correia at openbossa.org> has asked  for review:
Bug 105156: [EFL] Process launcher uses system() for wrapping the WebProcess
when using WEB_PROCESS_CMD_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=105156

Attachment 201462: Patch
https://bugs.webkit.org/attachment.cgi?id=201462&action=review

------- Additional Comments from Sergio Correia <sergio.correia at openbossa.org>
1) using prefixed increment style; 2) storing the CString to avoid calling
utf8() twice; 3) using OwnArrayPtr + deleteOwnedArrayPtr to take care of the
deallocating the memory when the args variable goes out of scope.


More information about the webkit-reviews mailing list