[webkit-reviews] review denied: [Bug 115871] [WK2] Make it possible to read Viewport information from WKViewportAttributes : [Attachment 201367] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 14:36:36 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 115871: [WK2] Make it possible to read Viewport information from
WKViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=115871

Attachment 201367: Patch
https://bugs.webkit.org/attachment.cgi?id=201367&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I discussed this a bit with Jesus.

Exposing raw viewport attribute is a bad idea. The computation of the view
parameter depending on the page parameter is complex and it should be common to
all the ports.
It is really easy to fuck that up. The design of this should be such that
mistakes are difficult to make.


More information about the webkit-reviews mailing list