[webkit-reviews] review granted: [Bug 115921] [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform : [Attachment 201365] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 14:18:40 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 115921: [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h)
build targets into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115921

Attachment 201365: Patch
https://bugs.webkit.org/attachment.cgi?id=201365&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
LGTM. An interesting problem, though: apparently after building with this
patch, then removing it a clean build is required:
http://webkit-queues.appspot.com/results/406652 

I think we need to make libPlatform and libWebCore depend on the files list for
both (like we do here
http://trac.webkit.org/browser/trunk/Source/WebCore/GNUmakefile.am#L453)


More information about the webkit-reviews mailing list