[webkit-reviews] review granted: [Bug 115902] Caching of generated images in CSS should be smarter. : [Attachment 201354] Probably a patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 115902: Caching of generated images in CSS should be smarter.
https://bugs.webkit.org/show_bug.cgi?id=115902

Attachment 201354: Probably a patch
https://bugs.webkit.org/attachment.cgi?id=201354&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=201354&action=review


r=me, looks so much better.

> Source/WebCore/css/CSSImageGeneratorValue.cpp:38
> +static const double timeToKeepCachedGeneratedImagesInSeconds = 3;

Is there science behind this number?

> Source/WebCore/css/CSSImageGeneratorValue.cpp:100
> +void
CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired(DeferrableOneS
hotTimer<CachedGeneratedImage>*)
>  {
> -    m_images.add(size, image);
> +    m_owner.evictCachedGeneratedImage(m_size);

This is essentially "delete this" right? It would be good to add a comment
pointing out that the object is dead afterwards.