[webkit-reviews] review granted: [Bug 115900] Remove ScriptInstance.h : [Attachment 201338] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 10 05:45:37 PDT 2013
Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 115900: Remove ScriptInstance.h
https://bugs.webkit.org/show_bug.cgi?id=115900
Attachment 201338: Patch
https://bugs.webkit.org/attachment.cgi?id=201338&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201338&action=review
r=me
>> Source/WebCore/platform/graphics/wince/MediaPlayerProxy.h:56
>> - ScriptInstance pluginInstance();
>> + RefPtr<JSC::Bindings::Instance> pluginInstance();
>
> The return type should use PassRefPtr instead of RefPtr.
[readability/pass_ptr] [5]
wat
More information about the webkit-reviews
mailing list