[webkit-reviews] review denied: [Bug 115865] Web Inspector: implement runOpenPanel callback for WebKit2-hosted inspector page : [Attachment 201310] Patch v1b

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 115865: Web Inspector: implement runOpenPanel callback for WebKit2-hosted
inspector page
https://bugs.webkit.org/show_bug.cgi?id=115865

Attachment 201310: Patch v1b
https://bugs.webkit.org/attachment.cgi?id=201310&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201310&action=review


> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:237
> +    if (!inspectorWindow)

Sorry, I didn't mean to cause confusion. What you had before was fine. If
window is nil (which it is when the Inspector is docked) passing nil to
NSOpenPanel will create a modal dialog instead of a sheet. Now with this patch
Open does not work when docked. You can remove the ASSERT and early return.

I just wanted you to understand and test the docked vs windowed case and make
sure you get what you expect.