[webkit-reviews] review denied: [Bug 115278] Flash of un-animated content : [Attachment 201297] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 9 18:30:20 PDT 2013
Darin Adler <darin at apple.com> has denied Kevin Doughty <css at kxdx.org>'s request
for review:
Bug 115278: Flash of un-animated content
https://bugs.webkit.org/show_bug.cgi?id=115278
Attachment 201297: Patch
https://bugs.webkit.org/attachment.cgi?id=201297&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201297&action=review
Thanks for tackling this.
Need to use spaces, not tabs. Doesn’t compile on Mac, need to find out why.
> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:445
> + // Workaround for <rdar://problem/7311367> flash of un-animated content
<https://bugs.webkit.org/show_bug.cgi?id=115278>
Not a good WebKit comment. We need the comment to say briefly what this is
working around and why this works.
More information about the webkit-reviews
mailing list