[webkit-reviews] review granted: [Bug 115883] Don't trust character widths for internal OS X fonts in form controls : [Attachment 201306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 18:27:46 PDT 2013


Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 115883: Don't trust character widths for internal OS X fonts in form
controls
https://bugs.webkit.org/show_bug.cgi?id=115883

Attachment 201306: Patch
https://bugs.webkit.org/attachment.cgi?id=201306&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201306&action=review


> Source/WebCore/rendering/RenderTextControl.cpp:234
> +    if (family.startsWith('.'))
> +	   return false;

Needs a “why” comment.

Also, I’d put this before the map building code. It seems strange to have this
in between the map building and the use of the map.


More information about the webkit-reviews mailing list