[webkit-reviews] review granted: [Bug 115819] unskip webarchive tests on mac : [Attachment 201296] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 9 17:05:03 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 115819: unskip webarchive tests on mac
https://bugs.webkit.org/show_bug.cgi?id=115819
Attachment 201296: Patch
https://bugs.webkit.org/attachment.cgi?id=201296&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201296&action=review
> LayoutTests/platform/efl-wk2/TestExpectations:289
> +# non-Mac ports don't support webarchives
Webkit comment style:
comments are complete sentences with Upper case for the first character and a
period.
non-Mac port don't -> EFL doesn't.
> LayoutTests/platform/gtk-wk2/TestExpectations:199
> +# non-Mac ports don't support webarchives
ditto.
> LayoutTests/platform/qt-5.0-mac-wk2/TestExpectations:86
> +# QT Mac port doesn't support webarchives
QT -> Qt.
> LayoutTests/platform/qt-5.0-wk2/TestExpectations:104
> +# non-Mac ports don't support webarchives
ditto.
> LayoutTests/platform/wk2/TestExpectations:97
> +# setIconDatabaseEnabled not implemented in WebKitTestRunner
Comment style.
More information about the webkit-reviews
mailing list