[webkit-reviews] review denied: [Bug 115875] add atomicAdd and atomicSubtract : [Attachment 201278] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 115875: add atomicAdd and atomicSubtract
https://bugs.webkit.org/show_bug.cgi?id=115875

Attachment 201278: Patch
https://bugs.webkit.org/attachment.cgi?id=201278&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #0)
> Source/WTF/wtf/Atomics.h currently has atomicIncrement and atomicDecrement
for adding and subtracting 1 atomically, but there is no way to add and
subtract other values atomically using WTF.  This is needed in cases like
Source/WTF/wtf/text/StringImpl.h line 584, which increments a value by 2.
> 
> I added atomicAdd and atomicSubtract and tested it on Mac, but I'd prefer
someone try this on Windows before reviewing in case I forgot something
Windows-specific.

StringImpl does not use atomic ref-deref.

What is this for?