[webkit-reviews] review granted: [Bug 115870] Add a StorageStrategy hook for creating transient local storage namespaces : [Attachment 201270] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 115870: Add a StorageStrategy hook for creating transient local storage
namespaces
https://bugs.webkit.org/show_bug.cgi?id=115870

Attachment 201270: Patch
https://bugs.webkit.org/attachment.cgi?id=201270&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201270&action=review


r=me

> Source/WebCore/ChangeLog:42
> +2013-05-09  Anders Carlsson	<andersca at apple.com>
> +
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   This is needed so WebKit2 can create transient local storage
namespaces in the UI process.

Too many ChangeLogs. Stop padding your stats!

> Source/WebCore/workers/WorkerContext.h:141
> -	   virtual const SecurityOrigin* topOrigin() const OVERRIDE { return
m_topOrigin.get(); }
> +	   virtual SecurityOrigin* topOrigin() const OVERRIDE { return
m_topOrigin.get(); }

Good. Grumpy cat hates const.