[webkit-reviews] review granted: [Bug 115805] DFGArrayMode::fromObserved is too liberal when it sees different Array and NonArray shapes : [Attachment 201129] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 12:20:25 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 115805: DFGArrayMode::fromObserved is too liberal when it sees different
Array and NonArray shapes
https://bugs.webkit.org/show_bug.cgi?id=115805

Attachment 201129: Patch
https://bugs.webkit.org/attachment.cgi?id=201129&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201129&action=review


r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   instead of just shape, which can cause us to exit a lot in the case
that we saw have a NonArray.

Typo: Should be "...case that we saw...".


More information about the webkit-reviews mailing list