[webkit-reviews] review requested: [Bug 115804] Avoid unnecessary data copies when loading subresources with DoNotBufferData option : [Attachment 201252] New patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 115804: Avoid unnecessary data copies when loading subresources with
DoNotBufferData option
https://bugs.webkit.org/show_bug.cgi?id=115804

Attachment 201252: New patch
https://bugs.webkit.org/attachment.cgi?id=201252&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
I've renamed the methods, actually I've split data into 3 addDataBuffer and
addData to add data chunks to the resource when buffering/not buffering and
finishLoading called when all data has been received. this way we get rid of
the boolean parameter and cached resources only interested in the final data,
only implement finishLoading. I've also noticed that sendDataToResource is
confusing, so I've removed it to call resource methods directly. This way is
more obvious when data needs to be copied and when to call addData,
addDataBuffer or finishLoading.