[webkit-reviews] review granted: [Bug 115815] [BlackBerry] texmap code generates warnings : [Attachment 201095] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 9 02:04:21 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 115815: [BlackBerry] texmap code generates warnings
https://bugs.webkit.org/show_bug.cgi?id=115815
Attachment 201095: Patch
https://bugs.webkit.org/attachment.cgi?id=201095&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Ok in principle but fix the style before landing.
In cpp files, I think it should be (please check):
#include config
#include mainheader
#if Foobar
[...]
--
I also suggest you to comment the #endif with the condition when it makes
sense.
More information about the webkit-reviews
mailing list