[webkit-reviews] review denied: [Bug 115840] REGRESSION (r145680): No box shadow rendered on element with positioned child that obscures it : [Attachment 201136] Alternative patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 115840: REGRESSION (r145680): No box shadow rendered on element with
positioned child that obscures it
https://bugs.webkit.org/show_bug.cgi?id=115840

Attachment 201136: Alternative patch
https://bugs.webkit.org/attachment.cgi?id=201136&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201136&action=review


> Source/WebCore/rendering/RenderBox.cpp:1151
> +    LayoutRect backgroundRect = pixelSnappedIntRect(style()->boxShadow() ?
boxShadowExtent() : borderBoxRect());

I think it's confusing for a function called backgroundPaintedExtent() to
return the box shadow extent, unless you rename it to boxDecorationExtent().

This patch also means that you'll always consult box shadows for obscuration,
even when the background might be obscured and the shadow drawn separately. So
I prefer my patch.