[webkit-reviews] review denied: [Bug 115843] [BLACKBERRY]fix regression in Webpage : [Attachment 201130] Fix regression in WebPage and FrameLoaderClientBlackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 20:18:16 PDT 2013


Mary Wu <mary.wu at torchmobile.com.cn> has denied  review:
Bug 115843: [BLACKBERRY]fix regression in Webpage
https://bugs.webkit.org/show_bug.cgi?id=115843

Attachment 201130: Fix regression in WebPage and FrameLoaderClientBlackberry
https://bugs.webkit.org/attachment.cgi?id=201130&action=review

------- Additional Comments from Mary Wu <mary.wu at torchmobile.com.cn>
View in context: https://bugs.webkit.org/attachment.cgi?id=201130&action=review


> Source/WebKit/blackberry/ChangeLog:5
> +	   Reviewed by Mary Wu.

don't put here, it's internally review

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1192
> +   
requestCopy.setTargetType(BlackBerry::Platform::NetworkRequest::TargetIsDownloa
d);/*forceDownload=true*/

obvious mistake, you use NetworkRequest to initiate ResourceRequest?


More information about the webkit-reviews mailing list