[webkit-reviews] review granted: [Bug 115802] Allow blank spaces before colon (:) on CSS variable definition : [Attachment 201072] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 115802: Allow blank spaces before colon (:) on CSS variable definition
https://bugs.webkit.org/show_bug.cgi?id=115802

Attachment 201072: Patch
https://bugs.webkit.org/attachment.cgi?id=201072&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201072&action=review


r=me, but please do this without adding a new production

> Source/WebCore/css/CSSGrammar.y.in:1623
> -    VAR_DEFINITION ':' maybe_space expr prio {
> +    var_definition ':' maybe_space expr prio {
>  #if ENABLE_CSS_VARIABLES
>	   parser->storeVariableDeclaration($1,
parser->sinkFloatingValueList($4), $5);
>	   $$ = true;

It’s unnecessary to add a new production for this. Instead you should just add
the maybe_space to this production, and change $4 to $5 and $5 to $6.