[webkit-reviews] review granted: [Bug 115775] Make CanvasStyle a plain object instead of an RefCounted object : [Attachment 201029] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 115775: Make CanvasStyle a plain object instead of an RefCounted object
https://bugs.webkit.org/show_bug.cgi?id=115775

Attachment 201029: Patch
https://bugs.webkit.org/attachment.cgi?id=201029&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201029&action=review


r=me

> Source/WebCore/html/canvas/CanvasStyle.h:46
> +	   CanvasStyle(RGBA32);

I'd prefer this to be explicit.

> Source/WebCore/html/canvas/CanvasStyle.h:51
> +	   CanvasStyle(PassRefPtr<CanvasGradient>);
> +	   CanvasStyle(PassRefPtr<CanvasPattern>);

Ditto for these.

> Source/WebCore/html/canvas/CanvasStyle.h:111
> +	   Type m_type;

I'd make this member const, as it should never change after construction.