[webkit-reviews] review denied: [Bug 115777] [EFL] Add fake touch event handler for LayoutTests/fast/events/touch/frame-hover-update.html. : [Attachment 201038] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 115777: [EFL] Add fake touch event handler for
LayoutTests/fast/events/touch/frame-hover-update.html.
https://bugs.webkit.org/show_bug.cgi?id=115777

Attachment 201038: Patch
https://bugs.webkit.org/attachment.cgi?id=201038&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201038&action=review


> LayoutTests/ChangeLog:10
> +
> +	   Add touch event handler to set the needTouchEvents to true and send
> +	   touch event to the web process in the WK2.
> +

You need to explain why, not just how.

> LayoutTests/fast/events/touch/frame-hover-update.html:40
>      <script>
> +	   // We have to add at least one touch event handler to feed touch
event
> +	   // to the web process in the WK2.
> +	   document.addEventListener('touchstart', function() {}, false);
> +

I dont like WK2 specific comments. This makes it sounds like a work around