[webkit-reviews] review granted: [Bug 115740] [Mac] Inband text tracks are not in text track menu on Lion : [Attachment 201006] Out damned tabs!

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 115740: [Mac] Inband text tracks are not in text track menu on Lion
https://bugs.webkit.org/show_bug.cgi?id=115740

Attachment 201006: Out damned tabs!
https://bugs.webkit.org/attachment.cgi?id=201006&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201006&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacy
AVFObjC.mm:88
>  {
>      if (!m_playerItemTrack)
>	   return false;
> -    
> -    return [[[m_playerItemTrack assetTrack] mediaType]
isEqualToString:AVMediaTypeClosedCaption];
> +
> +    return true;
>  }

Seems like this can now be "return m_playerItemTrack"

>
Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacy
AVFObjC.mm:98
>  bool InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent() const
>  {
> -    if (!m_playerItemTrack)
> -	   return false;
> -    
> -    return [[m_playerItemTrack assetTrack]
hasMediaCharacteristic:AVMediaCharacteristicIsMainProgramContent];
> +    return m_playerItemTrack;
>  }

Which is the same as this now.