[webkit-reviews] review requested: [Bug 115705] Implement a probe mechanism for JIT generated code : [Attachment 201009] new and improved after addressing Michael's feedback.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 115705: Implement a probe mechanism for JIT generated code
https://bugs.webkit.org/show_bug.cgi?id=115705

Attachment 201009: new and improved after addressing Michael's feedback.
https://bugs.webkit.org/attachment.cgi?id=201009&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Also made the ProbeContext::dump() format a little prettier.  Here's a sample
of the new dump:

   ProbeContext 0x7fff531db8e0 {
     probeFunction: 0x10cc62320
     arg1: 0x10daa921b 4524249627
     arg2: 0x0 0
     jitStackFrame: 0x7fff531dba20
     cpu: {
	eax: 0x0000000112e8d850   4612216912
	ecx: 0x0000000112d5fd70   4610981232
	edx: 0x0000000000000002   2
	ebx: 0x000000000000000a   10
	esp: 0x00007fff531dba20   140734587845152
	ebp: 0x00007fff531dbac0   140734587845312
	esi: 0x0000000000000004   4
	edi: 0x000000000000010b   267
	 r8: 0x00007fff531db224   140734587843108
	 r9: 0x00007fff531db300   140734587843328
	r10: 0x000000006aef1ba1   1794055073
	r11: 0x0000000000000000   0
	r12: 0x0000000000000200   512
	r13: 0x00000001128b0128   4606066984
	r14: 0xffff000000000000   -281474976710656
	r15: 0xffff000000000002   -281474976710654
	eip: 0x0000368a34401873   59967210002547
       xmm0: 0x0000000000000000 0x408f4000447a0000		0	  1000
       xmm1: 0x0000000000000000 0x408f400000000000		0	  1000
       xmm2: 0x0000000000000000 0x40919c087ec61929		0      1127.01
       xmm3: 0x41d0000000000000 0x3ff00007b803b946    1.07374e+09      1.00001
       xmm4: 0x0000000000000000 0x40380628cbd1244a		0      24.0241
       xmm5: 0xeea8b849368b4800 0x007f9e5964eea0be   -1.14375e+225 2.81414e-306

       xmm6: 0x9e5964eeb0b94900 0x8b4d00007f9e5964   -1.76392e-162
-3.09024e-254
       xmm7: 0x00007f9e5964eeb8 0xba49098b4d00007f   6.93263e-310  -6.3203e-28
     }
   }