[webkit-reviews] review granted: [Bug 115768] Store the quotes in the same allocation as the QuotesData object : [Attachment 200992] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 115768: Store the quotes in the same allocation as the QuotesData object
https://bugs.webkit.org/show_bug.cgi?id=115768

Attachment 200992: Patch
https://bugs.webkit.org/attachment.cgi?id=200992&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200992&action=review


r=me!!!

> Source/WebCore/rendering/style/QuotesData.h:35
> +#if COMPILER(MSVC)
> +#pragma warning(push)
> +#pragma warning(disable: 4200) // Disable "zero-sized array in struct/union"
warning
> +#endif

Maybe we should just do this globally.

> Source/WebCore/rendering/style/QuotesData.h:51
> +    unsigned m_numQuotes;

m_numFoo doesn't sound very WebKitty. How about m_quoteCount?