[webkit-reviews] review granted: [Bug 115755] Devirtualize Document class type checking : [Attachment 200991] Cleanup

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 115755: Devirtualize Document class type checking
https://bugs.webkit.org/show_bug.cgi?id=115755

Attachment 200991: Cleanup
https://bugs.webkit.org/attachment.cgi?id=200991&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200991&action=review


> Source/WebCore/dom/Document.h:1486
> +    unsigned m_documentClasses;

I would just use a uchar8_t here. That way it fits on a word with the 3 boolean
bellow.

> Source/WebCore/html/HTMLDocument.h:78
> +    HTMLDocument(Frame*, const KURL&, unsigned documentClasses =
HTMLDocumentClass);

I think it should have a default of 0.

Otherwise, an caller may think passing something else override the
HTMLDocumentClass. Which is not true because the constructor does the right
thing.