[webkit-reviews] review granted: [Bug 115732] [Automake] Pass --no-demangle to the linker by default to get the mangled symbols : [Attachment 200921] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 15:19:47 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 115732: [Automake] Pass --no-demangle to the linker by default to get the
mangled symbols
https://bugs.webkit.org/show_bug.cgi?id=115732

Attachment 200921: Patch
https://bugs.webkit.org/attachment.cgi?id=200921&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
LGTM, except I'm worry it works in our jhbuilt environments just because it
sets LDFLAGS, so your += works. If you could make sure it also works when no
LDFLAGS are set in the environment, that would be great.


More information about the webkit-reviews mailing list