[webkit-reviews] review denied: [Bug 115724] Add layout test that lists all global constructors : [Attachment 200933] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 14:32:10 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 115724: Add layout test that lists all global constructors
https://bugs.webkit.org/show_bug.cgi?id=115724

Attachment 200933: Patch
https://bugs.webkit.org/attachment.cgi?id=200933&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
The test is a great idea. But the results have zero readability.
If one line fail, you would have no idea which constructor is failing the test.
The output needs to serialize the value of constructorName.


More information about the webkit-reviews mailing list