[webkit-reviews] review granted: [Bug 42324] WebKitTestRunner needs testRunner.dumpDOMAsWebArchive : [Attachment 200967] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 42324: WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324

Attachment 200967: Patch
https://bugs.webkit.org/attachment.cgi?id=200967&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200967&action=review


> Tools/ChangeLog:10
> +	   Added dumpDOMAsWebArchive javascript function to be called by test
cases.

JavaScript

> Tools/ChangeLog:21
> +	   Added dumpDOMAsWebArchive JS callback function that sets
m_whatToDump to DOMASWebArchive.

I think it's "As" not "AS". Too many caps :)

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:53
> +#import <CoreFoundation/CoreFoundation.h>

Isn't this already included by WebArchiveDumpSupport.h?