[webkit-reviews] review denied: [Bug 115733] Avoid unnecessary arguments copying inside GenericHashTraits methods : [Attachment 200922] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 12:53:01 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 115733: Avoid unnecessary arguments copying inside GenericHashTraits
methods
https://bugs.webkit.org/show_bug.cgi?id=115733

Attachment 200922: patch
https://bugs.webkit.org/attachment.cgi?id=200922&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I fail to see in which case this is relevant. Can you give more explanation in
the ChangeLog?

For this kind of patch, you should also include in the ChangeLog how much
smaller the binary becomes. For changes in inlines function, the binary size
often gives reviewers a good metric on how large the improvement is.


More information about the webkit-reviews mailing list