[webkit-reviews] review denied: [Bug 115736] Changing the style of a hidden div queues a repaint : [Attachment 200931] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 12:25:31 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied José Dapena Paz
<jdapena at igalia.com>'s request for review:
Bug 115736: Changing the style of a hidden div queues a repaint
https://bugs.webkit.org/show_bug.cgi?id=115736

Attachment 200931: Patch
https://bugs.webkit.org/attachment.cgi?id=200931&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200931&action=review


> Source/WebCore/rendering/style/RenderStyle.cpp:678
> +    if (visibility() == other->visibility() && visibility() == HIDDEN)
> +	   return StyleDifferenceEqual;

You can't do this; you'll miss out on other styles tested later, which may be
different.


More information about the webkit-reviews mailing list