[webkit-reviews] review granted: [Bug 115711] REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal : [Attachment 200940] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 115711: REGRESSION(r149647): Assertion failure in
LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
https://bugs.webkit.org/show_bug.cgi?id=115711

Attachment 200940: Patch
https://bugs.webkit.org/attachment.cgi?id=200940&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200940&action=review


Great. r=me

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:64
>  void LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal(const
String& localStorageDirectory)
>  {

Would it make sense to return early if m_localStorageDirectory ==
localStorageDirectory?