[webkit-reviews] review denied: [Bug 42324] WebKitTestRunner needs testRunner.dumpDOMAsWebArchive : [Attachment 200927] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 42324: WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324

Attachment 200927: Patch
https://bugs.webkit.org/attachment.cgi?id=200927&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200927&action=review


> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:850
> +    const unsigned char* bytes = WKDataGetBytes(wkData);
> +    size_t length = WKDataGetSize(wkData);
> +    CFDataRef cfData = CFDataCreate(0, bytes, length);

This could be all-in-one-line too.

Also, you're leaking the CFData object.