[webkit-reviews] review denied: [Bug 115710] Disabled select element should not fire onchange event : [Attachment 200870] Fixes the bug

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 115710: Disabled select element should not fire onchange event
https://bugs.webkit.org/show_bug.cgi?id=115710

Attachment 200870: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=200870&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200870&action=review


> Source/WebCore/html/HTMLSelectElement.cpp:640
>  void HTMLSelectElement::listBoxOnChange()
>  {
>      ASSERT(!usesMenuList() || m_multiple);
> +    if (isDisabledFormControl())
> +	   return;

This just disables event dispatching. The root cause is that selection state is
updated even though the <select> is disabled.