[webkit-reviews] review granted: [Bug 115684] ftp branch: Fix broken 32-bit build + clean up JITStubs.cpp a bit. : [Attachment 200857] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 115684: ftp branch: Fix broken 32-bit build + clean up JITStubs.cpp a bit.
https://bugs.webkit.org/show_bug.cgi?id=115684

Attachment 200857: the patch.
https://bugs.webkit.org/attachment.cgi?id=200857&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200857&action=review


> Source/JavaScriptCore/jit/JITStubs.cpp:312
> -#else // USE(JSVALUE32_64)
> +#else // !USE(JSVALUE32_64)
>  
>  #if COMPILER(GCC) && CPU(X86_64)
>  

I believe the style in other WebKit code is to annotate a dependent
preprocessor macro with the heading for the macro's start. So, in this case,
"USE(JSVALUE32_64)" is correct.