[webkit-reviews] review granted: [Bug 115627] [SH4] Misc bugfix and cleaning in sh4 base JIT : [Attachment 200650] Misc bugfix and cleaning in sh4 base JIT

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Julien Brianceau
<jbrianceau at nds.com>'s request for review:
Bug 115627: [SH4] Misc bugfix and cleaning in sh4 base JIT
https://bugs.webkit.org/show_bug.cgi?id=115627

Attachment 200650: Misc bugfix and cleaning in sh4 base JIT
https://bugs.webkit.org/attachment.cgi?id=200650&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200650&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:673
> +	   RegisterID scr = (dest == base) ? claimScratch() : dest;

This seems common enough that you may want to make a function to do it
automagically - getScratch(dest, base) or something?