[webkit-reviews] review granted: [Bug 114808] [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5 : [Attachment 200704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 6 09:10:35 PDT 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 114808: [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been
removed from Qt 5
https://bugs.webkit.org/show_bug.cgi?id=114808

Attachment 200704: Patch
https://bugs.webkit.org/attachment.cgi?id=200704&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200704&action=review


> Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:69
> +	       // Remove this as soon as we depend on Qt 5.1

I think you can omit the comment, it won't be necessary to remove it before we
completely stop supporting Qt 5.0 in trunk.


More information about the webkit-reviews mailing list