[webkit-reviews] review granted: [Bug 115548] Manage the presentation of the snapshotted plug-in using JavaScript : [Attachment 200595] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 115548: Manage the presentation of the snapshotted plug-in using JavaScript
https://bugs.webkit.org/show_bug.cgi?id=115548

Attachment 200595: Patch
https://bugs.webkit.org/attachment.cgi?id=200595&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200595&action=review


I hope it's ok to potentially have a lot of isolated worlds in a page.

> Source/WebCore/css/plugIns.css:57
> +    
> +    top: 5px;

blank line?

> Source/WebCore/dom/Document.cpp:6068
> +   
page()->mainFrame()->script()->evaluateInWorld(ScriptSourceCode(jsString),
world);
> +
> +    m_hasInjectedPlugInsScript = true;

Maybe here we should also check that there is now a createWorld function. This
could be in a followup.