[webkit-reviews] review denied: [Bug 95178] Support CSS3 Keyboard control : [Attachment 200300] css3 keyboard navigation patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has denied Sangho Kim <thomas.kim at lge.com>'s
request for review:
Bug 95178: Support CSS3 Keyboard control
https://bugs.webkit.org/show_bug.cgi?id=95178

Attachment 200300: css3 keyboard navigation patch
https://bugs.webkit.org/attachment.cgi?id=200300&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200300&action=review


It sounds like we shouldn't be implementing this at all. Regardless, r- because
this should be behind an ENABLE-flag, and new features should be announced on
webkit-dev.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:206
> +    DataRef<StyleNavDirection> m_navUp;
> +    DataRef<StyleNavDirection> m_navDown;
> +    DataRef<StyleNavDirection> m_navLeft;
> +    DataRef<StyleNavDirection> m_navRight;
> +    DataRef<StyleNavIndex>	  m_navIndex;

I don't like the idea of growing StyleRareNonInheritedData by 5 whole pointers
for a single feature that's not used on the web yet. Can we make group this
stuff under a single pointer here?