[webkit-reviews] review denied: [Bug 115513] Improving PageSerializer.cpp to retrieve the subresources specified in @media rules in css : [Attachment 200522] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Santosh Mahto
<santoshbit2007 at gmail.com>'s request for review:
Bug 115513: Improving PageSerializer.cpp to retrieve the subresources specified
in @media rules in css
https://bugs.webkit.org/show_bug.cgi?id=115513

Attachment 200522: Patch
https://bugs.webkit.org/attachment.cgi?id=200522&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200522&action=review


> Source/WebCore/ChangeLog:11
> +	   Test file : Test.html (saving this file in mhtml format)

You forgot to include the test in this patch.

> Source/WebCore/page/PageSerializer.cpp:281
> +	       WTF::Vector<RefPtr<StyleRuleBase> > rules =
mediaStyle->childRules();

Remove the WTF::

> Source/WebCore/page/PageSerializer.cpp:284
> +	       unsigned ruleSize = rules.size();
> +	       for (unsigned i = 0; i < ruleSize; ++i) {

unsigned -> size_t.

> Source/WebCore/page/PageSerializer.cpp:286
> +		   if (rules[i]->isStyleRule())
> +		      
retrieveResourcesForRule(static_cast<StyleRule*>(rules[i].get()), document);

Because operator[] is a checked access, you shoudl store rules[i] in a
temporary variable:
    RefPtr<StyleRuleBase> rule = rules[i];
    if (rule->etc