[webkit-reviews] review granted: [Bug 115596] Update code generators to handle a new JavaScript file for snapshotted plug-ins : [Attachment 200542] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 4 14:04:44 PDT 2013


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 115596: Update code generators to handle a new JavaScript file for
snapshotted plug-ins
https://bugs.webkit.org/show_bug.cgi?id=115596

Attachment 200542: Patch
https://bugs.webkit.org/attachment.cgi?id=200542&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200542&action=review


> Source/WebCore/ChangeLog:22
> +	   * CMakeLists.txt:
> +	   * DerivedSources.cpp:
> +	   * DerivedSources.make:
> +	   * DerivedSources.pri:
> +	   * GNUmakefile.am:
> +	   * GNUmakefile.list.am:
> +	   * Resources/plugIns.js: Added.
> +	   * WebCore.vcproj/WebCore.vcproj:
> +	   * WebCore.vcxproj/WebCore.vcxproj:
> +	   * WebCore.vcxproj/WebCore.vcxproj.filters:
> +	   * WebCore.xcodeproj/project.pbxproj:

You should at least give quick descriptions of what you're changing here,
especially when you're adding new rule blocks.


More information about the webkit-reviews mailing list