[webkit-reviews] review canceled: [Bug 115576] There should be a runtime option to constrain what functions get DFG compiled : [Attachment 200504] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has canceled  review:
Bug 115576: There should be a runtime option to constrain what functions get
DFG compiled
https://bugs.webkit.org/show_bug.cgi?id=115576

Attachment 200504: Patch
https://bugs.webkit.org/attachment.cgi?id=200504&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200504&action=review


>>> Source/JavaScriptCore/runtime/Options.cpp:75
>>> +static bool parse(const char* string, optionRange& value)
>> 
>> Does it work correctly if you use OptionRange& here instead of the typedef?
I know there are some subtleties with how the macros automatically generate
stuff, but I dislike how this looks.
> 
> We can use OptionRange& here.  The typedef was put in so the enum and union
type work with the FOR_EACH_OPTION macros.

We can use OptionRange here.  The typedef was put in for the enum and type
within the union.