[webkit-reviews] review granted: [Bug 115581] Remove CSS selector profiler branches from ElementRuleCollector loop. : [Attachment 200514] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 115581: Remove CSS selector profiler branches from ElementRuleCollector
loop.
https://bugs.webkit.org/show_bug.cgi?id=115581

Attachment 200514: Patch
https://bugs.webkit.org/attachment.cgi?id=200514&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=200514&action=review


> Source/WebCore/css/ElementRuleCollector.cpp:409
> +    if (InspectorInstrumentation::hasFrontends())
> +	   doCollectMatchingRulesForList<true>(rules, matchRequest, ruleRange);

> +    else
> +	   doCollectMatchingRulesForList<false>(rules, matchRequest,
ruleRange);

Please use early return for the exceptional path. UNLIKELY might be good too.