[webkit-reviews] review granted: [Bug 115570] Remove concept of younger and older shadow trees : [Attachment 200513] with test updates

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 115570: Remove concept of younger and older shadow trees
https://bugs.webkit.org/show_bug.cgi?id=115570

Attachment 200513: with test updates
https://bugs.webkit.org/attachment.cgi?id=200513&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200513&action=review


r=meh

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:86
> +	   if (ShadowRoot* root = shadow->shadowRoot()) {

This code no longer holds a ref on the ShadowRoot.

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:104
> +	   if (ShadowRoot* root = shadow->shadowRoot())

Ditto.

> Source/WebCore/dom/ElementShadow.cpp:101
> +    ASSERT(shadowRoot());
> +    if (ShadowRoot* root = shadowRoot()) {

Yuck.

> Source/WebCore/dom/ElementShadow.cpp:111
> +    ASSERT(shadowRoot());
> +    if (ShadowRoot* root = shadowRoot()) {

Bleh.

> Source/WebCore/svg/SVGUseElement.cpp:397
> -    if (ShadowRoot* shadowTreeRootElement =	shadow()->oldestShadowRoot())
> +    if (ShadowRoot* shadowTreeRootElement =	shadow()->shadowRoot())

Please fix the whitespace here. Then re-run performance tests.