[webkit-reviews] review granted: [Bug 115576] There should be a runtime option to constrain what functions get DFG compiled : [Attachment 200504] Patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 115576: There should be a runtime option to constrain what functions get
DFG compiled
https://bugs.webkit.org/show_bug.cgi?id=115576

Attachment 200504: Patch
https://bugs.webkit.org/attachment.cgi?id=200504&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200504&action=review


r=me with comments.

> Source/JavaScriptCore/runtime/Options.cpp:75
> +static bool parse(const char* string, optionRange& value)

Does it work correctly if you use OptionRange& here instead of the typedef? I
know there are some subtleties with how the macros automatically generate
stuff, but I dislike how this looks.